On 07/11/2025 08:50, Krzysztof Kozlowski wrote: > On Thu, Nov 06, 2025 at 07:42:24PM +0530, Swamil Jain wrote: >> From: Louis Chauvet <[email protected]> >> >> The dt-bindings for the multi-function device (mfd) syscon need to include >> ti,am625-dss-clk-ctrl. On AM62X, AM62A and AM62P devicess, the display >> controller (tidss) has external registers to control certain clock >> properties. These registers are located in the device configuration >> registers, so they need to be declared using syscon. They will later be >> used with a phandle in the tidss node. >> >> Fixes: ad2ac9dc9426 ("drm/tidss: Add support for AM625 DSS") >> Fixes: 5cc5ea7b6d7b ("drm/tidss: Add support for AM62A7 DSS") > > Adding missing hardware is not a fix. Drop both. > >> Cc: [email protected] > > For sure not a stable commit. You just add new hardware. > >> Signed-off-by: Louis Chauvet <[email protected]> >> Signed-off-by: Swamil Jain <[email protected]> >> --- >> Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > With these fixed/dropped: > > Acked-by: Krzysztof Kozlowski <[email protected]>
Un-acked, NAK. You just ignored previous feedback. Best regards, Krzysztof
