Re: [PATCH 20/39] drm/imx: dc: Configure display CSR clock feed select

[Marek Vasut]

On 10/13/25 8:48 PM, Frank Li wrote:

Hello Frank,
@@ -119,6 +127,17 @@ static int dc_drm_bind(struct device *dev)
        if (ret)
                return ret;

+       if (priv->regmap) {
+               regmap_write_bits(priv->regmap, DISPLAY_ENGINES_CLOCK_CONTROL,
+                                 DISP_CLK0_SEL | DISP_CLK1_SEL,
+                                 FIELD_PREP(DISP_CLK0_SEL,
+                                            ((dc_drm->encoder[0].encoder_type 
== DRM_MODE_ENCODER_DSI) ?
+                                            DISP_CLK_SEL_CCM : 
DISP_CLK_SEL_LVDS)) |
+                                 FIELD_PREP(DISP_CLK1_SEL,
+                                            ((dc_drm->encoder[1].encoder_type 
== DRM_MODE_ENCODER_DSI) ?
+                                            DISP_CLK_SEL_CCM : 
DISP_CLK_SEL_LVDS)));
+       }
+

why not export as clock providor and use clk API to do that?
I don't think there are any clock operations 
(enable/disable/set_rate/...) besides controlling this selector/mux 
(set_parent), so using the clock API would have massive overhead for 
little gain.