#21080: collectstatic post-processing fails for references inside comments
-------------------------------------+------------------------------------
Reporter: shreyas@… | Owner: blighj
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Changes (by blighj):
* needs_better_patch: 0 => 1
Comment:
I've added a post to the [[https://forum.djangoproject.com/t/django-
manifeststaticfiles-enhanced-improving-
manifeststaticfilesstorage/41956|forum]] to ask for feedback on the 3rd
party package. I did some performance testing and the slow down was worse
than I expected. To alleviate that, I've made handling dependencies in
substitution files more efficient. This is now done with a graph and in
one substitution pass. So you don't end up calling the lexer multiple
times on the same file. This keeps the performance the same as the current
approach.
Gonna mark this as patch needs improvement, see if I get any take up on
the package and then update the PR's with the newer approach from the
package. If anyone was looking to review this I suggest providing feedback
on the package repo for now.
--
Ticket URL: <https://code.djangoproject.com/ticket/21080#comment:38>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701982d34fad3-3e236f65-e922-4c39-ad8f-5a4fb907620a-000000%40eu-central-1.amazonses.com.
