On 10/16/2012 04:00 AM, Łukasz Rekucki wrote: > If we include some form of a test runner in every localflvour, I > suspect they will get out of sync quite quickly. Also, I don't think > there is a good reason for duplicating code.
David's pull request seems pretty minimal to me - just a three-line settings.py and a tox.ini. It would be nice to have some more-automatic way to keep the tox.ini up to date. > Maybe we need something like django-localflavour-commons, which would > include the test harness, packaging logic (then in setup.py you can > just import it from there), etc. My first idea was to make it a > submodule, but that would still require making a commit to all repos > whenever we update the commons (althought, still simpler then applying > the same patch everywhere). We could instead put it on PyPI and make > all other packages always require it's latetest version. Be really careful with importing things in setup.py. A runtime dependency is different from a can't-even-execute-setup.py-without-it dependency; the latter means pip wouldn't even be able to install a localflavor package unless you install the -commons package first (in a separate step). (Setuptools has setup_requires to get around that, but it's wonky with pip, as it won't respect any of pip's index/mirror/find-links settings, and always goes to the main PyPI). I don't think there's nearly enough common "packaging logic" in the localflavors to justify any of this hassle. A localflavor-dev package that includes requirements for running tests on all localflavors (and has a dependency on tox, so the instructions are still as simple as "pip install one thing and run one command") might be ok, though the main duplication you'd want to save is in tox.ini, and you'd need to write some extra code to help tox "inherit" config files before you'd be able to save any redundancy there anyway. Carl -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
