Here's another pull request for setting up testing, this time using tox as per Russell's suggestion. https://github.com/django/django-localflavor-gb/pull/2
AFAIK, tox requires the tests to be part of the package. Hence I moved tests.py into the django_localflavor_gb package as well as a test settings module. Using Django's testrunner also requires that the package has a models.py so it is considered an app. Is is possible to use tox and the django testrunner so that the test can be separate, and the package doesn't require a models.py? That would be cleaner in my eyes. Feedback welcome of course. Hopefully this is a step in the right direction for agreeing on a testing set-up for all the localflavors. On 16 October 2012 04:55, Mahdi Yusuf <yusuf.ma...@gmail.com> wrote: > Hi, > > I have setup testing in a pull request > here<https://github.com/django/django-localflavor-us/pull/1> > . > > If this solution is acceptable. I can duplicate the process on the other > local flavours. > > I would appreciate feedback. > > -- > Mahdi Yusuf > > On Mon, Oct 15, 2012 at 4:16 PM, Aymeric Augustin < > aymeric.augus...@polytechnique.org> wrote: > >> Hi Adrian, >> >> Thanks for taking the lead on this! I reviewed related tickets in Trac >> and I have a few suggestions. >> >> >> 1) Can we move the fields defined in >> django.contrib.localflavor.generic.forms to django.forms? >> >> Currently the US-biased fields are in django.forms and the non-biased >> ones in django.contrib.localflavor.generic.forms — an interesting >> perspective :) >> >> The alternative is to deprecate them entirely. >> >> >> 2) There's a dozen Trac tickets for adding new countries: Bulgaria, >> Nicaragua, Hungary, Malaysia, Venezuela, South Korea, Bangladesh, New >> Zealand, Guatemala, Latvia, Iran, Singapore. >> >> Would it make sense to create these local flavors now — maybe after >> asking the community to update the patches if they aren't ready? >> >> >> 3) I'd like to see some guidelines on what features a local flavor is >> expected to provide. >> >> Two examples: >> - Are model fields that just inherit TextField and set a particular >> form_class useful? (#10087) >> - Are pluralization template filters a good idea? (#17632) >> >> I believe it's a good thing for the Django community to maintaining some >> consistency among local flavors. Since we plan to defer to local >> maintainers in each country, we should document the expectations and best >> practices. >> >> >> -- >> Aymeric. >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To post to this group, send email to django-developers@googlegroups.com. >> To unsubscribe from this group, send email to >> django-developers+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/django-developers?hl=en. >> >> > > > -- > Mahdi Yusuf > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > -- *David Winterbottom* Head of Programming Tangent Labs 84-86 Great Portland Street London W1W 7NR England, UK -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
