On 16 October 2012 11:21, David Winterbottom <david.winterbot...@tangentlabs.co.uk> wrote: > Here's another pull request for setting up testing, this time using tox as > per Russell's suggestion. > https://github.com/django/django-localflavor-gb/pull/2 > > AFAIK, tox requires the tests to be part of the package. Hence I moved > tests.py into the django_localflavor_gb package as well as a test settings > module. Using Django's testrunner also requires that the package has a > models.py so it is considered an app. Is is possible to use tox and the > django testrunner so that the test can be separate, and the package doesn't > require a models.py? That would be cleaner in my eyes. > > Feedback welcome of course. Hopefully this is a step in the right direction > for agreeing on a testing set-up for all the localflavors. > > On 16 October 2012 04:55, Mahdi Yusuf <yusuf.ma...@gmail.com> wrote: >> >> Hi, >> >> I have setup testing in a pull request here. >> >> If this solution is acceptable. I can duplicate the process on the other >> local flavours. >> >> I would appreciate feedback. >> >> -- >> Mahdi Yusuf
If we include some form of a test runner in every localflvour, I suspect they will get out of sync quite quickly. Also, I don't think there is a good reason for duplicating code. Maybe we need something like django-localflavour-commons, which would include the test harness, packaging logic (then in setup.py you can just import it from there), etc. My first idea was to make it a submodule, but that would still require making a commit to all repos whenever we update the commons (althought, still simpler then applying the same patch everywhere). We could instead put it on PyPI and make all other packages always require it's latetest version. -- Łukasz Rekucki -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
