On May 18, 2012, at 12:19 PM, Anssi Kääriäinen wrote:
> I do not want us to have single commit per pull request. Instead I
> would like to see nice clean logical commits. These make bisecting as
> easy as possible. So, we mostly agree here.

My feeling is that we want every commit in the main tree to be a working 
commit, even if its an early one in a multi-commit pull. This doesn't 
eliminate the possibility of multi-commit pull requests, but it seems to 
point to most small-change pull requests typically being a single commit.

I'm not entirely sure what that should mean to feature branches that get 
merged in, since they can often be very large and start with commits that 
don't have the feature working. Probably that they just need to make sure 
that each commit along the way does not break anything outside of the new 
feature.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to