On May 18, 8:43 pm, Donald Stufft <donald.stu...@gmail.com> wrote:
> In my experience, squash makes git bisect harder, instead finding the bad
> commit to be a small, atomic change, you're often given a large change where
> you must then determine which change out of the entire commit caused the 
> issue.

I do not want us to have single commit per pull request. Instead I
would like to see nice clean logical commits. These make bisecting as
easy as possible. So, we mostly agree here.

If you edit a file I do think it is a good idea to have two separate
commits if one is for whitespace cleanup of already existing errors in
the file, and then another for your actual changes. But there should
not be two commits if one is for your changes, and then another for
whitespace cleanup of _your changes_.

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to