On May 18, 6:04 pm, Carl Meyer <c...@oddbird.net> wrote: > All in all, I would be -1 on making rebase a required part of > contributing to Django. I would prefer to leave this choice up to the > contributor, and say something like: > > "If you want your own name on the final commit in master, feel free to > rebase your pull request down to a single commit with a well-formatted > commit message. Otherwise, we will 'merge --squash' your pull request > into a single commit on master, and credit you in the commit message."
I agree here - the WIP docs mention something to the tone of "the less of the work you do the worse your chances of getting you request in". It should probably be a little more allowing. Maybe your paragraph and a mention that those who aim to continuously provide patches to Django should learn how to create good quality pull requests. When the core committers know a contributor and trust the contributor's pull requests, there isn't a long way left to become a core committer... - Anssi -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
