oraluben commented on code in PR #300: URL: https://github.com/apache/tvm-ffi/pull/300#discussion_r2633227177
########## cmake/Utils/EmbedCubin.cmake: ########## @@ -15,205 +15,163 @@ # specific language governing permissions and limitations # under the License. +# Do not let cmake to link cudart. +set(CMAKE_CUDA_RUNTIME_LIBRARY None) Review Comment: > I'm curious about the point regarding the driver version constraints: > > > This imposes an extra constraint on the driver version - it requires the exact CUDA driver bundled with that cudart, not just a compatible one. Have a typo here, it requires **at least** the exact CUDA Driver bundled with that cudart, not all compatible ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
