oraluben commented on code in PR #300:
URL: https://github.com/apache/tvm-ffi/pull/300#discussion_r2630292532
##########
examples/cubin_launcher/dynamic_cubin/src/lib_dynamic.cc:
##########
@@ -80,14 +80,19 @@ void AddOne(tvm::ffi::TensorView x, tvm::ffi::TensorView y)
{
// Get CUDA stream
DLDevice device = x.device();
- cudaStream_t stream =
- static_cast<cudaStream_t>(TVMFFIEnvGetStream(device.device_type,
device.device_id));
+ tvm::ffi::StreamHandle stream =
+
static_cast<tvm::ffi::StreamHandle>(TVMFFIEnvGetStream(device.device_type,
device.device_id));
// Launch kernel
- cudaError_t result = g_add_one_kernel->Launch(args, grid, block, stream);
+ tvm::ffi::ResultHandle result = g_add_one_kernel->Launch(args, grid, block,
stream);
Review Comment:
Name updated for now, need more discuss about the high-level design of
`unify_api.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
