oraluben commented on PR #300: URL: https://github.com/apache/tvm-ffi/pull/300#issuecomment-3685084867
> I asked Gemini on the best parctice of indicating "internal-only" header and it suggests us to use some "detail" subfolder and define the internal functions in "details" namespace. Maybe we can create a "detail" subfolder like /include/tvm/ffi/extra/cuda/detail and define the compatibility layer in a "details" namespace. My gemini also prefers "detail", but I do think "internal" would be better :) Currently we have `tvm/ffi/extras/cuda/internal/unified_api.h` and a new namespace `tvm::ffi::cuda_api` for all those internal type/impls. I believe all comments have been resolved, PTAL again @yaoyaoding cc @junrushao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
