Thanks for this RFC Cody! I fully agree this pass should be re-implemented 
using the pattern language, the logic was very much a stop-gap solution until 
more powerful pattern matching appeared.

Do you envisage this having a similar API to the existing pass? In particular 
it's important for us to retain the added 'check' function to confirm whether a 
match is valid. 

Looking forward slightly, I do wonder whether it will start making sense to 
instead of creating composite functions just directly insert the annotations 
around the match. This would give us an opportunity to link up 'composite' 
matches with single ops as it's currently quite unintuitive that these two 
things are treated so differently.





---
[Visit 
Topic](https://discuss.tvm.ai/t/byoc-use-pattern-language-to-create-composite-functions/6727/13)
 to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click 
here](https://discuss.tvm.ai/email/unsubscribe/93f40307ef07673b09bc508439cb9d2a22b46ae4d715b0afff3f1ee29a21adc2).

Reply via email to