https://issues.apache.org/bugzilla/show_bug.cgi?id=57021
--- Comment #10 from Mark Thomas <ma...@apache.org> --- Some further feedback 1. Indents should be with 4 spaces not tabs. 2. In LibraryNotFoundError libraryName is better than nameOfLibrary 3. Improvement B requested name*s* of the libraries, not just one. 4. The patch always throws an Exception on the first name. There is never a chance to check the second name. 5. Improvement A is not addressed. 6. Javadoc for LibraryNotFoundError adds no value. Yes, neither does much of the Javadoc in that package but that is not a reason to continue in the same direction. 7. Log messages inr AprLifecycleListener.init should not be made directly to the logger. Check the svn history for that file to find out why. In applying and reviewing the patch I have fixed the various issues so I should be committing this fairly soon. Don't be concerned about how much has been changed. The first patch I offered was unrecognisable by the time Bill had finished with it. Your first patch is a lot better than my first patch. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
