https://issues.apache.org/bugzilla/show_bug.cgi?id=57021

--- Comment #5 from Mark Thomas <ma...@apache.org> ---
@Chris the difference with WARN and DEBUG is that DEBUG includes the stack
trace. I'd say if debug is not enabled, log at WARN, else log at DEBUG so you
never get more than one message.

Some more comments.

1. Check line length. Some appear to be over to 100 char limit for code lines.

2. Don't comment out code to disable it. Delete it. Just think how many lines
must have been deleted/changed in the last 10+ years. If we want to look at an
old version we'll use the version control system tools. We do not want to be
wading through reams of commented out code.

3. Try not to mix code formatting changes (e.g adding blank lines) with
functional changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to