https://issues.apache.org/bugzilla/show_bug.cgi?id=57021
--- Comment #19 from Mark Thomas <ma...@apache.org> --- (In reply to VIN from comment #16) > (In reply to Mark Thomas from comment #10) > > Some further feedback > > > > 1. Indents should be with 4 spaces not tabs. > Hi Mark, > I changed the code using Eclipse editor which by default adds tab as > indent. Next time on wards i will open the changed code in notepad and check > the indents. You can change this per project in Eclipse. > > 3. Improvement B requested name*s* of the libraries, not just one. > As per the enhancement mentioned in the request, Tomcat code should not > try to load the second library when the first library failed to load. So I > thought there is no point in maintaining array of library names. > > Please correct me if my understanding is wrong. There is a difference between the library being found and not loading (error immediately) vs the library not being found and not loading (try the next name). If all names fail we still need to log all names. > > 4. The patch always throws an Exception on the first name. There is never a > > chance to check the second name. > > As per the enhancement mentioned in request, code should not try load > the second library. That's why I intentionally returned the exception (throw > t;). > > Please correct me if my understanding is wrong. See above. > > 5. Improvement A is not addressed. I meant C. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
