On 23/12/2011 12:58, Olivier Lamy wrote:
> Hello,
>
> 2011/12/23 Mark Thomas <ma...@apache.org>:
>> On 22/12/2011 13:48, Olivier Lamy wrote:
>>> In o.a.t.u.m.Registry with changing
>>>
>>> private ModelerSource getModelerSource( String type )
>>> throws Exception
>>> {
>>> if( type==null ) type="MbeansDescriptorsDigesterSource";
>>> //if( type.indexOf( "" ) < 0 ) {
>>> if (type.length()>0) {
>>> type="org.apache.tomcat.util.modeler.modules." + type;
>>> }
>>>
>>> Class<?> c = Class.forName(type);
>>> ModelerSource ds=(ModelerSource)c.newInstance();
>>> return ds;
>>> }
>>>
>>> package was never added so CNFE.
>>> I wonder what is the need for this test ?
>>
>> I've look at the code in trunk and it doesn't look quite like the
>> snippet above.
>
> It's on tc7.0.x branch (
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/Registry.java
> )
>
> BTW as you said for this maven build poc the best is probably to work
> against trunk codebase.
In this case trunk and 7.0.x/trunk are identical and neither agree with
the code snippet above. I still do not understand what the question is.
> What do you think about I commit some stuff in sandbox path ? (
> http://svn.apache.org/repos/asf/tomcat/sandbox/trunk-mvn-build )
> Maybe it's a path open for all asf committers ? so people interested
> to work on that can help ?
Doing the work in the sandbox would certainly make it more visible so
folks on the dev list can see what is happening more easily. We can get
the relevant part of svn published to the ASF Git mirrors if that helps.
Just my $0.02
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
