In o.a.t.u.m.Registry with changing

    private ModelerSource getModelerSource( String type )
            throws Exception
    {
        if( type==null ) type="MbeansDescriptorsDigesterSource";
        //if( type.indexOf( "" ) < 0 ) {
        if (type.length()>0) {
            type="org.apache.tomcat.util.modeler.modules." + type;
        }

        Class<?> c = Class.forName(type);
        ModelerSource ds=(ModelerSource)c.newInstance();
        return ds;
    }

package was never added so CNFE.
I wonder what is the need for this test ?


2011/12/22 Olivier Lamy <ol...@apache.org>:
> Hello,
> I have added the distro packaging (commons-daemon* and
> tomcat-native.tar.gz not yet done).
>
> I still have weird issues which I don't' yet understand:
>
> when runing unit test
> from the top module
>
> mvn clean install -Dtest=TestCompositeELResolver
> ....
> GRAVE: Error loading
> jar:file:/Users/olamy/dev/sources/tomcat/tomcat70/tomcat-catalina/target/tomcat-catalina-7.0.24-SNAPSHOT.jar!/org/apache/catalina/mbeans/mbeans-descriptors.xml
> ....
>
> or using the generated distro
> mvn clean install -DskipTests
> I have added for testing convenience an exploded distro so:
> cd 
> apache-tomcat/target/apache-tomcat-7.0.24-SNAPSHOT-bin/apache-tomcat-7.0.24-SNAPSHOT/bin/
>
> same error in catalina.out
>
> 22 d<8E>c. 2011 14:21:04 org.apache.tomcat.util.modeler.Registry 
> loadDescriptors
> GRAVE: Error loading
> jar:file:/Users/olamy/dev/sources/tomcat/tomcat70/apache-tomcat/target/apache-tomcat-7.0.24-SNAPSHOT-bin/apache-tomcat-7.0.24-SNAPSHOT/lib/catalina.jar!/org/apache/catalina/mbeans/mbeans-descriptors.xml
>
> I will start debugging.
> For enable debugging in your ide (after the first install of all
> dependent modules), you can use: mvn clean install
> -Dtest=TestCompositeELResolver -pl :tomcat-tests
> -Dmaven.surefire.debug=true
> debug port will be 5005.
>
> Someone with ideas on the exact cause of this ?
>
> 2011/12/21 Olivier Lamy <ol...@apache.org>:
>> Hello,
>> I have started some stuff here: https://github.com/olamy/tomcat70.
>>
>> * sources have been to appropriate modules.
>> * I'm now working on some test which fail (some tests need webapp examples)
>> * distro not yet done.
>> * repackaging of dbcp pool, commons-logging is done using shading technology
>> * I will work with jbonofre (who is karaf committer) to add necessary
>> stuff to osgiing.
>>
>> NOTE: It's really work in progress not finish (so pull requests will
>> be accepted :-) )
>>
>> 2011/12/20 Mark Thomas <ma...@apache.org>:
>>> On 20/12/2011 08:17, Antonio Petrelli wrote:
>>>> 2011/12/19 Mladen Turk <mt...@apache.org>
>>>>
>>>>> On 12/19/2011 07:04 PM, Henri Gomez wrote:
>>>>>
>>>>>> Exactly. Since any change would require a learning curve
>>>>>>> and it seems we don't have that many (read none) maven
>>>>>>> experts in the house, Gradle could be equally considered,
>>>>>>> given that it seems more advanced in customization.
>>>>>>>
>>>>>>
>>>>>> I know well Maven but Olivier (Lamy) is a Maven expert, so there is
>>>>>> friend in the business.
>>>>>> And there is a full Maven PMC not too far ready to provide advices and
>>>>>> help.
>>>>>> Not counting Tomcat consumers ASF projects like OpenEJB.
>>>>>>
>>>>>>
>>>>> All I have seen so far is talk and talk and more talk.
>>>>> There is trunk, branches, sandbox, so anyone is free to
>>>>> make a proposal and if things work, I'll be the first
>>>>> one supporting it.
>>>>>
>>>>
>>>> I already forked my own repository from GitHub. I hope to start it after
>>>> the holidays.
>>>
>>> I would be very interested in seeing what a Mavenised build of trunk
>>> looks like.
>>>
>>> While I may come across as anti-Maven, that is not my position. I am
>>> anti *any* disruptive change that causes more disruption then benefit it
>>> brings and right now I see more disruption than I do benefit.
>>>
>>> I am also wary (from my experience of infrastructure at the ASF) of
>>> folks pushing strongly for a switch to something better, promising to
>>> help with the switch and promising to support things moving forwards and
>>> then melting away just as their support is really needed.
>>>
>>> A demonstration of a fully Mavenised build of Tomcat trunk (or 7.0.x,
>>> 6.0.x or 5.5.x) at GitHub would help considerably:
>>> - we would be able to see how all the potential wrinkles (down-loading
>>> JDT, building a packages renamed DBCP, building a package renamed
>>> Commons logging, etc) were handled in Maven
>>> - we'd be able to judge how much simpler the build process was
>>> - Maven newbies like me could try building it, debugging with it and
>>> developing with it to see how easy we found it
>>> - the work required to create it would demonstrate a commitment to
>>> supporting this change
>>>
>>> I should stress that a working Mavenised build of a version of Tomcat is
>>> necessary but not sufficient to get my support for a switch from Ant to
>>> Maven for the build / release process.
>>>
>>> Mark
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>>
>>
>> --
>> Olivier Lamy
>> Talend: http://coders.talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
>
>
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to