https://issues.apache.org/bugzilla/show_bug.cgi?id=49811
--- Comment #6 from Mark Thomas <ma...@apache.org> 2010-08-29 11:18:42 EDT --- Overall this looks pretty good. Just some minor clean-up required before it is ready to be proposed for 6.0.x (In reply to comment #3) > I would recommend calling this configuration attribute/parameter > "disableURLRewriting" instead of "allowURLSessions". First, it includes the > word "rewriting" which is what the servlet spec calls this, and second, it > indicates that the default is that URL rewriting is ENABLED. +1 > Please mention in the Javadoc that by setting this config parameter to TRUE > (that is, disabling URL rewriting), you are breaking the servlet specification > (mention chapter and verse, just to be clear). +1 > It may even be worth writing to the log file during Context startup. -0 > Also, spell-check your javadoc ;) +1 > You should probably also change the URL-parsing code that accepts jsessionid > parameters and have it ignore URL-supplied jsessionids, The proposed changes look sufficient to me. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
