Filip Hanik - Dev Lists wrote:
As far as I know, the accumulated request processing times retrieved
via the MBeans for Servlets or the GlobalRequestProcessor are correct.
I simply don't want to break them.
I had a quick look, and our confusion might come from the fact, that
RequestInfo contains a processingTime and a requestProcessingTime. The
first one gets updated when the request is recycled and accumulates
the processing times. That's the one that always worked. The other one
is e.g. used when showing a full status in the html manager and is the
one you want to fix.
Forget the part from here ...
You might consider to return as requestProcessingTime instead of "0"
when no request is running (as you suggest) the time taken for the
last request before as detected by updateCounters(). Both ways have
their advantages (detecting idleness vs. detecting last request time).
I didn't check though, if updateCounters is called unconditionally
(wrt. configuration).
... to here. I forgot, that you already introduced
lastRequestProcessingTime, which does exactly, what I was thinking here.
Forget this piece.
again, I am very confused. not sure why you are talking about
processingTime, since that property has nothing to do with the patch,
and is working.
That's exactly what I was trying to state above the nonsense part. This
wasn't meant to argue pro or contra your patch, I only tried to explain,
why I mentioned (erroneously) the GlobalRequestProcessor in my first mail.
- lastRequestProcssingTime: This item is new but apart from the new
setter and getter not used, especially not in the
getRequestProcessingTime fix. If this data is needed, shouldn't we
also expose it via the mbean descriptor? It's nice for a statistic
sampling of response times.
where is the mbean-descriptor for this? I thought JMX just pulled it
out using reflection
Indeed. I don't really understand, which method gets used when. The
session managers e.g. have the processingTime in the mbeans
descriptors, as well as standard context and standard wrapper.
GlobalRequestProcessor and Servlet MBeans seem to use reflection.
besides the typo, I'm unclear on the rest of your comments and how they
pertain to the patch :)
1) Since processingTime != requestProcessingTime your patch doesn't
influence the existing working behaviour of GlobalRequestProcessor and
Servlet MBeans (that was a question in my first mail, which I tried to
answer myself in the second mail). So OK for the patch.
2) Since you already introduced lastRequestProcessingTime, the
additional suggestion in my second mail is obsolete. So OK for your patch.
3) I wonder, under which circumstances we use reflection vs.
mbeans-descriptors.xml to configure our MBeans. No insight yet, but not
directly related to your patch.
Filip
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
