Rainer Jung wrote:
Hi Filip,
I guess that also fixes the misleading html manager display (request
times going up and up). That would be very nice.
Just a quick shot:
- maybe you can fix Procssing -> Processing everywhere
not sure what you mean?
- will this change the behaviour of the requestProcessingTime as one
can retrieve from the MBeans of the GlobalRequestProcessor or
Servlets? I guess (and hope) no?
yes it does, requestProcessingTime is incorrect, has always been, as it
goes up and up when the request is not in use. Why wouldn't you want to
change it?
- lastRequestProcssingTime: This item is new but apart from the new
setter and getter not used, especially not in the
getRequestProcessingTime fix. If this data is needed, shouldn't we
also expose it via the mbean descriptor? It's nice for a statistic
sampling of response times.
where is the mbean-descriptor for this? I thought JMX just pulled it out
using reflection
Filip
Regards,
Rainer
Filip Hanik - Dev Lists wrote:
here is the modified patch
Filip
Bill Barker wrote:
I would think that using the stage would be more reliable than
hacking the
startTime, but otherwise, I have no strong opinion either way.
-----Original Message-----
From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] Sent:
Monday, September 24, 2007 11:49 AM
To: Tomcat Developers List
Subject: 6.0.x request processing patch
Currently, the RequestInfo.getRequestProcessingTime is not taking
into account if the request is active or not, hence returning a
larger and larger value if a new request is not received.
The patch addresses the following
1. getRequestProcessingTime returns 0 if no request is active
2. getLastRequestProcessingTime will return the time for the last
request
Does anyone think the values that are returned should be different?
thoughts?
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
