Rémy,
On 12/3/24 10:38 AM, Rémy Maucherat wrote:
On Mon, Dec 2, 2024 at 6:12 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
Rémy,
On 12/2/24 9:56 AM, Rémy Maucherat wrote:
I saw that this was not tested at all, so I had a look at it.
Are there any uses of this ? If there are, I think this should be
rewritten as a generic access logger like the JSON one, using a
DataSource like all the other Tomcat components. Right now, it
pretends to do common or combined patterns access logging (actually:
it logs stuff but it's not strictly these patterns). The existing
JDBCAccessLogValve would be deprecated and kept around in Tomcat 11
(and older) since it is now tested.
Is there anyone even vaguely interested in that feature ? If so I'll
do it, since I wrote down some prototype ideas for it in a class. If
no one thinks a database backed access log is a worthy feature, we
should instead deprecate and remove it in 12.
I think these days, everybody uses Elastic/Open/etc for such things if
they aren't going to use file-based logging. I think we can drop it.
It also seems unusable to me as it is, with its giant lock on a single
JDBC connection. I will deprecate it from all branches, then remove it
in main/12.
As you do that, please add an entry in the "important changes" section
of the migration guide. While it will affect probably nobody, it's
definitely an "important change". ;)
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
