вт, 3 дек. 2024 г. в 18:38, Rémy Maucherat <r...@apache.org>: > > On Mon, Dec 2, 2024 at 6:12 PM Christopher Schultz > <ch...@christopherschultz.net> wrote: > > > > Rémy, > > > > On 12/2/24 9:56 AM, Rémy Maucherat wrote: > > > I saw that this was not tested at all, so I had a look at it. > > > > > > Are there any uses of this ? If there are, I think this should be > > > rewritten as a generic access logger like the JSON one, using a > > > DataSource like all the other Tomcat components. Right now, it > > > pretends to do common or combined patterns access logging (actually: > > > it logs stuff but it's not strictly these patterns). The existing > > > JDBCAccessLogValve would be deprecated and kept around in Tomcat 11 > > > (and older) since it is now tested. > > > > > > Is there anyone even vaguely interested in that feature ? If so I'll > > > do it, since I wrote down some prototype ideas for it in a class. If > > > no one thinks a database backed access log is a worthy feature, we > > > should instead deprecate and remove it in 12. > > > > I think these days, everybody uses Elastic/Open/etc for such things if > > they aren't going to use file-based logging. I think we can drop it. > > It also seems unusable to me as it is, with its giant lock on a single > JDBC connection. I will deprecate it from all branches, then remove it > in main/12.
It is not customizable (supports only two patterns, "common" and "combined"), does not support conditions (pre-filtering via conditionIf, conditionUnless), and is not documented - the only documentation is its JavaDoc. It is missing from config/valve.html > "Access Logging". +1 for removal Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
