Hi, I saw that this was not tested at all, so I had a look at it.
Are there any uses of this ? If there are, I think this should be rewritten as a generic access logger like the JSON one, using a DataSource like all the other Tomcat components. Right now, it pretends to do common or combined patterns access logging (actually: it logs stuff but it's not strictly these patterns). The existing JDBCAccessLogValve would be deprecated and kept around in Tomcat 11 (and older) since it is now tested. Is there anyone even vaguely interested in that feature ? If so I'll do it, since I wrote down some prototype ideas for it in a class. If no one thinks a database backed access log is a worthy feature, we should instead deprecate and remove it in 12. Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
