This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push: new 84cf12a638 Additional comment to explain choice of LinkedList 84cf12a638 is described below commit 84cf12a638bc5415743bcde10c4191eee00fa1a1 Author: Mark Thomas <ma...@apache.org> AuthorDate: Wed Oct 5 18:01:49 2022 +0100 Additional comment to explain choice of LinkedList --- java/org/apache/catalina/session/ManagerBase.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/java/org/apache/catalina/session/ManagerBase.java b/java/org/apache/catalina/session/ManagerBase.java index e4b5662a6b..dd0ffbf223 100644 --- a/java/org/apache/catalina/session/ManagerBase.java +++ b/java/org/apache/catalina/session/ManagerBase.java @@ -120,11 +120,9 @@ public abstract class ManagerBase extends LifecycleMBeanBase implements Manager protected static final int TIMING_STATS_CACHE_SIZE = 100; - protected final Deque<SessionTiming> sessionCreationTiming = - new LinkedList<>(); - - protected final Deque<SessionTiming> sessionExpirationTiming = - new LinkedList<>(); + // Use LinkedList as the Deques are initialised by filling with null + protected final Deque<SessionTiming> sessionCreationTiming = new LinkedList<>(); + protected final Deque<SessionTiming> sessionExpirationTiming = new LinkedList<>(); /** * Number of sessions that have expired. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org