This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new a83fd9e607 Additional comment to explain choice of LinkedList
a83fd9e607 is described below
commit a83fd9e607c22cb0e3b27f2cebd9e9fc385eb5a2
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Oct 5 18:01:49 2022 +0100
Additional comment to explain choice of LinkedList
---
java/org/apache/catalina/session/ManagerBase.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/catalina/session/ManagerBase.java
b/java/org/apache/catalina/session/ManagerBase.java
index d142701d43..c78b1ae4c2 100644
--- a/java/org/apache/catalina/session/ManagerBase.java
+++ b/java/org/apache/catalina/session/ManagerBase.java
@@ -120,11 +120,9 @@ public abstract class ManagerBase extends
LifecycleMBeanBase implements Manager
protected static final int TIMING_STATS_CACHE_SIZE = 100;
- protected final Deque<SessionTiming> sessionCreationTiming =
- new LinkedList<>();
-
- protected final Deque<SessionTiming> sessionExpirationTiming =
- new LinkedList<>();
+ // Use LinkedList as the Deques are initialised by filling with null
+ protected final Deque<SessionTiming> sessionCreationTiming = new
LinkedList<>();
+ protected final Deque<SessionTiming> sessionExpirationTiming = new
LinkedList<>();
/**
* Number of sessions that have expired.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
