This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push: new 22cd0726f5 Additional comment to explain choice of LinkedList 22cd0726f5 is described below commit 22cd0726f5d629a79d9e886fe7daf01142438396 Author: Mark Thomas <ma...@apache.org> AuthorDate: Wed Oct 5 18:01:49 2022 +0100 Additional comment to explain choice of LinkedList --- java/org/apache/catalina/session/ManagerBase.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/java/org/apache/catalina/session/ManagerBase.java b/java/org/apache/catalina/session/ManagerBase.java index 7b9ab5042d..d0af97df23 100644 --- a/java/org/apache/catalina/session/ManagerBase.java +++ b/java/org/apache/catalina/session/ManagerBase.java @@ -120,11 +120,9 @@ public abstract class ManagerBase extends LifecycleMBeanBase implements Manager protected static final int TIMING_STATS_CACHE_SIZE = 100; - protected final Deque<SessionTiming> sessionCreationTiming = - new LinkedList<>(); - - protected final Deque<SessionTiming> sessionExpirationTiming = - new LinkedList<>(); + // Use LinkedList as the Deques are initialised by filling with null + protected final Deque<SessionTiming> sessionCreationTiming = new LinkedList<>(); + protected final Deque<SessionTiming> sessionExpirationTiming = new LinkedList<>(); /** * Number of sessions that have expired. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org