[
https://issues.apache.org/jira/browse/TINKERPOP-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199878#comment-15199878
]
ASF GitHub Bot commented on TINKERPOP-1219:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197966824
After more discussions with @dkuppitz on the side, he showed me where the
break was occurring. The difference is in:
```text
// This is TP31:
gremlin> g.V(1).values("name")
==>marko
gremlin> g.V().hasId(1).values("name")
==>marko
gremlin> g.V("1").values("name")
gremlin> g.V().hasId("1").values("name")
==>marko
// This is the PR:
gremlin> g.V(1).values("name")
==>marko
gremlin> g.V().hasId(1).values("name")
==>marko
gremlin> g.V("1").values("name")
gremlin> g.V().hasId("1").values("name")
gremlin>
````
He prefers this behavior in this PR, which is fine and should be the break
documented explicitly for TinkerGraph in upgrade docs, with the note that
configuration of an id manager allows things to work perfectly as a I showed
above.
I also took a momen to test Neo4j directly - this confirmed it's just a
TinkerGraph issue:
```text
gremlin> graph = Neo4jGraph.open('/tmp/neo4j-test')
==>neo4jgraph[Community [/tmp/neo4j-test]]
gremlin> graph.addVertex("name","stephen")
==>v[0]
gremlin> graph.addVertex("name","daniel")
==>v[1]
gremlin> g = graph.traversal()
==>graphtraversalsource[neo4jgraph[Community [/tmp/neo4j-test]], standard]
gremlin> g.V(1).values("name")
==>daniel
gremlin> g.V().hasId(1).values("name")
==>daniel
gremlin> g.V("1").values("name")
==>daniel
gremlin> g.V().hasId("1").values("name")
==>daniel
```
I would still love to solve TINKERPOP-1048 and get it all completely
settled, but I think what we have here is ok especially since the existing
tests didn't break or change. with all that in mind:
VOTE +1
> Create a test case that ensures the provider's compilation of g.V(x) and
> g.V().hasId(x) is identical
> ----------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1219
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1219
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.1-incubating
> Reporter: Mike Dias
> Assignee: Marko A. Rodriguez
> Priority: Minor
> Labels: breaking, test
> Fix For: 3.1.2-incubating
>
>
> As discussed in this topic:
> https://groups.google.com/forum/#!topic/gremlin-users/Kz2bOeAeqh4
> It will ensure the same behavior between g.V().hasId(id) vs. g.V(id) and
> graph.vertices(id)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
