[
https://issues.apache.org/jira/browse/TINKERPOP-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199464#comment-15199464
]
ASF GitHub Bot commented on TINKERPOP-1219:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/267#issuecomment-197869261
oops - I was voting +1 without the understanding that this constituted a
breaking change. I figured the id magic issue might be sorted out separately,
but if this somehow breaks that, then I guess +1 was the wrong answer.
so - with that, i still don't fully understand where the break is. All the
old tests still pass don't they? Am I missing where you modified/removed the
tests that check for appropriate id semantics?
Perhaps the id magic is bad - it's already not perfect as you saw from
Daniel above - this issue details some of the problems with getting TinkerGraph
completely compliant:
https://issues.apache.org/jira/browse/TINKERPOP-1048
Maybe there's a better way to get the id semantics tests to pass than what
i'm doing in the `HasContainer`. I just don't know what it is offhand.
> Create a test case that ensures the provider's compilation of g.V(x) and
> g.V().hasId(x) is identical
> ----------------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1219
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1219
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.1.1-incubating
> Reporter: Mike Dias
> Assignee: Marko A. Rodriguez
> Priority: Minor
> Labels: breaking, test
> Fix For: 3.1.2-incubating
>
>
> As discussed in this topic:
> https://groups.google.com/forum/#!topic/gremlin-users/Kz2bOeAeqh4
> It will ensure the same behavior between g.V().hasId(id) vs. g.V(id) and
> graph.vertices(id)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
