[jira] [Commented] (TINKERPOP-1219) Create a test case that ensures the provider's compilation of g.V(x) and g.V().hasId(x) is identical

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TINKERPOP-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197881#comment-15197881
 ] 

ASF GitHub Bot commented on TINKERPOP-1219:
-------------------------------------------

Github user mikedias commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/267#discussion_r56389186
  
    --- Diff: 
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/HasTest.java
 ---
    @@ -354,6 +365,33 @@ public void g_V_hasXlocationX() {
             checkResults(Arrays.asList(convertToVertex(graph, "marko"), 
convertToVertex(graph, "stephen"), convertToVertex(graph, "daniel"), 
convertToVertex(graph, "matthias")), traversal);
         }
     
    +    @Test
    +    @LoadGraphWith(MODERN)
    +    @IgnoreEngine(TraversalEngine.Type.COMPUTER) // only validate for OLTP
    +    public void g_V_hasId_compilationEquality() {
    +        final Traversal<Vertex, Vertex> traversala1 = 
get_g_VX1X(convertToVertexId("marko"));
    +        final Traversal<Vertex, Vertex> traversala2 = 
get_g_V_hasIdX1X(convertToVertexId("marko"));
    +        final Traversal<Vertex, Vertex> traversalb1 = 
get_g_VX1_2X(convertToVertexId("marko"), convertToVertexId("vadas"));
    +        final Traversal<Vertex, Vertex> traversalb2 = 
get_g_V_hasIdX1_2X(convertToVertexId("marko"), convertToVertexId("vadas"));
    +        printTraversalForm(traversala1);
    +        printTraversalForm(traversala2);
    +        printTraversalForm(traversalb1);
    +        printTraversalForm(traversala2);
    --- End diff --
    
    small typo: traversala2 -> traversalb2


> Create a test case that ensures the provider's compilation of g.V(x) and 
> g.V().hasId(x) is identical
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1219
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1219
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.1.1-incubating
>            Reporter: Mike Dias
>            Assignee: Marko A. Rodriguez
>            Priority: Minor
>              Labels: breaking, test
>             Fix For: 3.1.2-incubating
>
>
> As discussed in this topic: 
> https://groups.google.com/forum/#!topic/gremlin-users/Kz2bOeAeqh4
> It will ensure the same behavior between g.V().hasId(id) vs. g.V(id) and 
> graph.vertices(id)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)