[
https://issues.apache.org/jira/browse/TINKERPOP-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154328#comment-15154328
]
ASF GitHub Bot commented on TINKERPOP-1153:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/230#issuecomment-186256034
So weird. Again, overnight.
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop .................................. SUCCESS [5.222s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [2.530s]
[INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS [38.401s]
[INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [11.325s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS [32.358s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [6.013s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS
[3:15.039s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS
[5:03.753s]
[INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS
[10:01.122s]
[INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS
[2:24:33.823s]
[INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS
[17:40.001s]
[INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS [8.919s]
[INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS
[10:56.373s]
[INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS
[1:08.209s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 3:14:23.560s
[INFO] Finished at: Thu Feb 18 21:43:01 MST 2016
[INFO] Final Memory: 94M/708M
[INFO]
------------------------------------------------------------------------
```
Here I will just comment out that test. If you guys can tell me what result
of the query is in the console I can fix it later, but without it failing here,
I have no idea.
> Add ByModulating and TimesModulating interfaces.
> ------------------------------------------------
>
> Key: TINKERPOP-1153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1153
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.2-incubating
> Reporter: Marko A. Rodriguez
> Fix For: 3.2.0-incubating
>
>
> Currently {{GraphTraversal}} is responsible for the logic for {{by()}}- and
> {{times()}}-modulators. For instance, if you do:
> {code}
> ...by('name')
> {code}
> It is {{GraphTraversal}} that will compile that to
> {{__.values('name').limit(1)}}. This should not be the logic of
> {{GraphTraversal}}, but instead, logic within the step being modulated. Thus,
> I propose:
> {code}
> public interface ByModulating {
> public void add(String string) throws UnsupportedOperationException
> public void add(Traversal traversal) throws UnsupportedOperationException
> public void add(T t) throws UnsupportedOperationException
> }
> {code}
> Likewise for {{TimesModulating}} ... and any other modulators down the road.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
