[
https://issues.apache.org/jira/browse/TINKERPOP-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151651#comment-15151651
]
ASF GitHub Bot commented on TINKERPOP-1153:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/230#issuecomment-185521157
VOTE +1.
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop .................................. SUCCESS [5.044s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [2.132s]
[INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS [38.711s]
[INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [12.019s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS [32.419s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [6.354s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS
[3:27.877s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS
[5:07.110s]
[INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS
[10:39.819s]
[INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS
[2:21:44.149s]
[INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS
[17:29.014s]
[INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS [8.910s]
[INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS
[10:56.703s]
[INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS
[1:08.703s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 3:12:19.462s
[INFO] Finished at: Wed Feb 17 19:59:19 MST 2016
[INFO] Final Memory: 93M/731M
[INFO]
------------------------------------------------------------------------
~/software/tinkerpop/tinkerpop3$
```
> Add ByModulating and TimesModulating interfaces.
> ------------------------------------------------
>
> Key: TINKERPOP-1153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1153
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.2-incubating
> Reporter: Marko A. Rodriguez
> Fix For: 3.2.0-incubating
>
>
> Currently {{GraphTraversal}} is responsible for the logic for {{by()}}- and
> {{times()}}-modulators. For instance, if you do:
> {code}
> ...by('name')
> {code}
> It is {{GraphTraversal}} that will compile that to
> {{__.values('name').limit(1)}}. This should not be the logic of
> {{GraphTraversal}}, but instead, logic within the step being modulated. Thus,
> I propose:
> {code}
> public interface ByModulating {
> public void add(String string) throws UnsupportedOperationException
> public void add(Traversal traversal) throws UnsupportedOperationException
> public void add(T t) throws UnsupportedOperationException
> }
> {code}
> Likewise for {{TimesModulating}} ... and any other modulators down the road.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
