[
https://issues.apache.org/jira/browse/TINKERPOP-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153492#comment-15153492
]
ASF GitHub Bot commented on TINKERPOP-1153:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/230#issuecomment-186004389
@dkuppitz ... that is weird. It all finished for me just now. Can you run
the query in the console and tell me what you get:
```
g.V().hasLabel("software").has("name",
"ripple").pageRank(1.0).by(__.inE("created")).times(1).by("priors").in("created").union(__.both(),
__.identity()).valueMap("name", "priors")
```
```
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop .................................. SUCCESS [4.355s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [3.344s]
[INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS [38.227s]
[INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [11.285s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS [32.956s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [6.191s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS
[3:16.894s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS
[5:01.567s]
[INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS
[10:15.725s]
[INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS
[2:24:31.663s]
[INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS
[17:33.444s]
[INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS [9.075s]
[INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS
[10:55.872s]
[INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS
[1:08.465s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 3:14:29.536s
[INFO] Finished at: Thu Feb 18 17:46:39 MST 2016
[INFO] Final Memory: 95M/707M
[INFO]
------------------------------------------------------------------------
```
> Add ByModulating and TimesModulating interfaces.
> ------------------------------------------------
>
> Key: TINKERPOP-1153
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1153
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.2-incubating
> Reporter: Marko A. Rodriguez
> Fix For: 3.2.0-incubating
>
>
> Currently {{GraphTraversal}} is responsible for the logic for {{by()}}- and
> {{times()}}-modulators. For instance, if you do:
> {code}
> ...by('name')
> {code}
> It is {{GraphTraversal}} that will compile that to
> {{__.values('name').limit(1)}}. This should not be the logic of
> {{GraphTraversal}}, but instead, logic within the step being modulated. Thus,
> I propose:
> {code}
> public interface ByModulating {
> public void add(String string) throws UnsupportedOperationException
> public void add(Traversal traversal) throws UnsupportedOperationException
> public void add(T t) throws UnsupportedOperationException
> }
> {code}
> Likewise for {{TimesModulating}} ... and any other modulators down the road.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
