[
https://issues.apache.org/jira/browse/TINKERPOP-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686750#comment-17686750
] ASF GitHub Bot commented on TINKERPOP-2841: ------------------------------------------- codecov-commenter commented on PR #1968: URL: https://github.com/apache/tinkerpop/pull/1968#issuecomment-1424734505 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1968](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e269ac) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/cd70be2923260ba8de71af5a72071153f7a622fe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd70be2) will **decrease** coverage by `5.14%`. > The diff coverage is `93.44%`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1968 +/- ## ============================================= - Coverage 69.26% 64.13% -5.14% ============================================= Files 865 25 -840 Lines 41095 3733 -37362 Branches 5418 0 -5418 ============================================= - Hits 28466 2394 -26072 + Misses 10712 1162 -9550 + Partials 1917 177 -1740 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [gremlin-go/driver/driverRemoteConnection.go](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZHJpdmVyUmVtb3RlQ29ubmVjdGlvbi5nbw==) | `85.10% <0.00%> (-1.23%)` | :arrow_down: | | [gremlin-go/driver/client.go](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY2xpZW50Lmdv) | `80.80% <100.00%> (+1.23%)` | :arrow_up: | | [gremlin-go/driver/request.go](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVxdWVzdC5nbw==) | `80.83% <100.00%> (+1.93%)` | :arrow_up: | | [gremlin-go/driver/requestOptions.go](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVxdWVzdE9wdGlvbnMuZ28=) | `100.00% <100.00%> (ø)` | | | [...emlin/driver/ser/RequestMessageGryoSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9zZXIvUmVxdWVzdE1lc3NhZ2VHcnlvU2VyaWFsaXplci5qYXZh) | | | | [...e/tinkerpop/gremlin/server/util/MetricManager.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL01ldHJpY01hbmFnZXIuamF2YQ==) | | | | [...in/process/traversal/step/map/SampleLocalStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9TYW1wbGVMb2NhbFN0ZXAuamF2YQ==) | | | | [...tinkerpop/gremlin/structure/util/GraphFactory.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9HcmFwaEZhY3RvcnkuamF2YQ==) | | | | [...op/gremlin/driver/exception/ResponseException.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9leGNlcHRpb24vUmVzcG9uc2VFeGNlcHRpb24uamF2YQ==) | | | | [.../process/traversal/step/map/LambdaFlatMapStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9MYW1iZGFGbGF0TWFwU3RlcC5qYXZh) | | | | ... and [836 more](https://codecov.io/gh/apache/tinkerpop/pull/1968?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Test and Fix Per Request Settings in Go > --------------------------------------- > > Key: TINKERPOP-2841 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2841 > Project: TinkerPop > Issue Type: Improvement > Components: go > Affects Versions: 3.7.0, 3.6.1, 3.5.4 > Reporter: Cole Greer > Priority: Major > > Gremlin go gives the option to override certain settings on a per request > basis (detailed > [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_4]). > It's been observed that when overriding the requestId, gremlin go will still > make and use a new requestId instead > ([here|https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/request.go#L54]). > All documented per request settings need to be tested and fixed if needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
