[ 
https://issues.apache.org/jira/browse/TINKERPOP-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675750#comment-17675750
 ] 

Cole Greer commented on TINKERPOP-2841:
---------------------------------------

Found that Go does send all per request settings but it does not format the 
arguments in the manner specified in the provider docs (as done with the java 
client).

[https://tinkerpop.apache.org/docs/current/dev/provider/#_opprocessors_arguments]

Sample Request Message from Java:

{{}}
{code:java}
RequestMessage{, requestId=19436d9e-f8fc-4b67-8a76-deec60918424, op='eval', 
processor='', args={gremlin=1, evaluationTimeout=1234, userAgent=helloWorld, 
batchSize=12}}{code}
{{}}

Sample Request Message from Go (Note how evaluationTimeout, batchSize… are 
nested within a “bindings” map):

{{}}
{code:java}
RequestMessage{, requestId=19436d9e-f8fc-4b67-8a76-deec60918424, op='eval', 
processor='', args={gremlin=x+x, aliases={g=g}, bindings={x=2}}}
{code}
{{}}

{{}}

> Test and Fix Per Request Settings in Go
> ---------------------------------------
>
>                 Key: TINKERPOP-2841
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2841
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: go
>    Affects Versions: 3.7.0, 3.6.1, 3.5.4
>            Reporter: Cole Greer
>            Priority: Major
>
> Gremlin go gives the option to override certain settings on a per request 
> basis (detailed 
> [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_4]).
>  It's been observed that when overriding the requestId, gremlin go will still 
> make and use a new requestId instead 
> ([here|https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/request.go#L54]).
>  All documented per request settings need to be tested and fixed if needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to