[
https://issues.apache.org/jira/browse/TINKERPOP-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675748#comment-17675748
]
ASF GitHub Bot commented on TINKERPOP-2841:
-------------------------------------------
Cole-Greer opened a new pull request, #1939:
URL: https://github.com/apache/tinkerpop/pull/1939
https://issues.apache.org/jira/browse/TINKERPOP-2841
In my testing, the go glv was not sending per-request options correctly to
the server. Go was passing request options inside the gremlin script bindings
map instead of within the args portion of the request message.
This PR re-implements the per-request settings by adding new
Client.SubmitWithOptions() and DriverRemoteConnection.SubmitWithOptions()
methods. Both original Submit() methods are unchanged in their behavior so this
will not break any users.
This PR introduces a new `RequestOptions` struct and builder which is used
to configure per-request settings and passed into the new SubmitWithOptions()
methods.
> Test and Fix Per Request Settings in Go
> ---------------------------------------
>
> Key: TINKERPOP-2841
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2841
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 3.7.0, 3.6.1, 3.5.4
> Reporter: Cole Greer
> Priority: Major
>
> Gremlin go gives the option to override certain settings on a per request
> basis (detailed
> [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_4]).
> It's been observed that when overriding the requestId, gremlin go will still
> make and use a new requestId instead
> ([here|https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/request.go#L54]).
> All documented per request settings need to be tested and fixed if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
