[
https://issues.apache.org/jira/browse/TINKERPOP-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684054#comment-17684054
]
ASF GitHub Bot commented on TINKERPOP-2853:
-------------------------------------------
Cole-Greer commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1416509263
Hi @tormodhau, are you still having trouble moving your branch over to
3.5-dev? Just to elaborate on Florian's suggestion, running the following
should fix any issues:
```
git reset HEAD~1
git stash
git reset --hard 3.5-dev
git stash apply
git add gremlin-dotnet/
git commit -m "Throw explaining exception when reading unsupported
GraphBinary type"
git push -f
```
Feel free to reach out if you have any other issues with submitting your PR.
> Gremlin.Net driver should throw better exception message for unsupported
> GraphBinary type
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2853
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2853
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.6.1, 3.5.4
> Reporter: Florian Hockmann
> Priority: Minor
>
> The driver currently throws an exception that isn't very telling:
> {code:java}
> System.Collections.Generic.KeyNotFoundException : The given key
> 'janusgraph.RelationIdentifier' was not present in the dictionary. {code}
> It would be good if it would instead clearly state that no serializer was
> found for the GraphBinary type. This was first reported [on the
> janusgraph-users
> list|https://lists.lfaidata.foundation/g/janusgraph-users/message/6673].
> The exception gets thrown
> [here|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L282]
> for types received from the server where no serializer is registered for the
> driver.
> For the write path however, the exception thrown [is already more
> telling|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L224].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
