[
https://issues.apache.org/jira/browse/TINKERPOP-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676765#comment-17676765
] ASF GitHub Bot commented on TINKERPOP-2853: ------------------------------------------- codecov-commenter commented on PR #1941: URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1382376699 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1941](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a0c5bb) into [master](https://codecov.io/gh/apache/tinkerpop/commit/4320add17fff518aac79379977c247dc4e3d7edf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4320add) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #1941 +/- ## ============================================ + Coverage 68.59% 68.60% +0.01% - Complexity 9085 9088 +3 ============================================ Files 854 854 Lines 41179 41179 Branches 5597 5597 ============================================ + Hits 28245 28252 +7 + Misses 10954 10951 -3 + Partials 1980 1976 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...al/strategy/optimization/ProductiveByStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9vcHRpbWl6YXRpb24vUHJvZHVjdGl2ZUJ5U3RyYXRlZ3kuamF2YQ==) | `78.57% <0.00%> (-8.93%)` | :arrow_down: | | [...apache/tinkerpop/gremlin/server/GremlinServer.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmVtbGluU2VydmVyLmphdmE=) | `56.09% <0.00%> (-1.96%)` | :arrow_down: | | [...pache/tinkerpop/gremlin/driver/ConnectionPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uUG9vbC5qYXZh) | `29.54% <0.00%> (+0.64%)` | :arrow_up: | | [...kergraph/process/computer/TinkerGraphComputer.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy9jb21wdXRlci9UaW5rZXJHcmFwaENvbXB1dGVyLmphdmE=) | `96.18% <0.00%> (+0.76%)` | :arrow_up: | | [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `91.02% <0.00%> (+0.96%)` | :arrow_up: | | [...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=) | `63.75% <0.00%> (+1.25%)` | :arrow_up: | | [...java/org/apache/tinkerpop/gremlin/driver/Host.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Ib3N0LmphdmE=) | `37.77% <0.00%> (+2.22%)` | :arrow_up: | | [.../gremlin/driver/exception/ConnectionException.java](https://codecov.io/gh/apache/tinkerpop/pull/1941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9leGNlcHRpb24vQ29ubmVjdGlvbkV4Y2VwdGlvbi5qYXZh) | `44.44% <0.00%> (+22.22%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Gremlin.Net driver should throw better exception message for unsupported > GraphBinary type > ----------------------------------------------------------------------------------------- > > Key: TINKERPOP-2853 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2853 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet > Affects Versions: 3.6.1, 3.5.4 > Reporter: Florian Hockmann > Priority: Minor > > The driver currently throws an exception that isn't very telling: > {code:java} > System.Collections.Generic.KeyNotFoundException : The given key > 'janusgraph.RelationIdentifier' was not present in the dictionary. {code} > It would be good if it would instead clearly state that no serializer was > found for the GraphBinary type. This was first reported [on the > janusgraph-users > list|https://lists.lfaidata.foundation/g/janusgraph-users/message/6673]. > The exception gets thrown > [here|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L282] > for types received from the server where no serializer is registered for the > driver. > For the write path however, the exception thrown [is already more > telling|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L224]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
