[
https://issues.apache.org/jira/browse/TINKERPOP-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677220#comment-17677220
]
ASF GitHub Bot commented on TINKERPOP-2853:
-------------------------------------------
FlorianHockmann commented on PR #1941:
URL: https://github.com/apache/tinkerpop/pull/1941#issuecomment-1383647445
> I made the changes from master, which I now see is pretty far from
apache:3.5-dev. Should I have started from 3.5-dev in the first place?
That would be ideal, yes. I guess the easiest way now is to do a soft reset
of your commit, stash it and then (hard) reset your branch on `3.5-dev`. After
that, it should be easy to apply your changes from the stash and commit it
again. Lastly, you can force push your branch which should let this PR end up
clean with just one commit that should be merged into `3.5-dev`.
If you need help with that, just say so.
Our branching strategy is that non-breaking changes, and especially bug
fixes, should target the lowest release branch still supported. This is
`3.5-dev` right now. We will then merge it into that branch and afterwards
merge it into the other release branches (`3.6-dev` and `master`) so it ends in
all upcoming releases.
> Gremlin.Net driver should throw better exception message for unsupported
> GraphBinary type
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2853
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2853
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.6.1, 3.5.4
> Reporter: Florian Hockmann
> Priority: Minor
>
> The driver currently throws an exception that isn't very telling:
> {code:java}
> System.Collections.Generic.KeyNotFoundException : The given key
> 'janusgraph.RelationIdentifier' was not present in the dictionary. {code}
> It would be good if it would instead clearly state that no serializer was
> found for the GraphBinary type. This was first reported [on the
> janusgraph-users
> list|https://lists.lfaidata.foundation/g/janusgraph-users/message/6673].
> The exception gets thrown
> [here|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L282]
> for types received from the server where no serializer is registered for the
> driver.
> For the write path however, the exception thrown [is already more
> telling|https://github.com/apache/tinkerpop/blob/60b2792d63604b3baec68201adf35ed7f1d1e558/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/TypeSerializerRegistry.cs#L224].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
