Of course looking at Java 8 especially JSR 310 (java.time) introduced horrible circular dependencies like TemporalUnit (in java.time.temporal, the only "API" like package of this JSR, the rest is RI our "core" equivalent) used by TemporalAmount but then references concrete class Duration (implements TemporalAmount) directly.
IMHO a total no-go, but strangely I was the only JCP EC member who seem to have even noticed the issue;-| Werner On Mon, Jan 26, 2015 at 12:31 PM, Reinhard Sandtner < [email protected]> wrote: > i wrote the TODO’s when i added the excludes to findbugs-exclude.xml > probably it's better to write our modules against the api but we must pay > attention to not copy-paste much code since we have it in java7/java8 > modules. > > our Tests are duplicated too - maybe we need something like a tck to have > a basic test-suite which can be used in java7 and java8 > > what’s the idea if i need the same code in 3 or more modules - do we > really want to copy paste the whole logic? > > lg > reini > > > Am 26.01.2015 um 12:12 schrieb Anatole Tresch <[email protected]>: > > > > +1 > > > > 2015-01-26 12:03 GMT+01:00 Werner Keil <[email protected]>: > > > >> Merging core and API would be a very bad move, even if there never was a > >> prospect of some (or all) of Tamaya being recognized as something JSR > >> worthy (remember the idea was discussed there but most people asked in > the > >> JCP thought it would be better to have a PoC project first, like > >> Hibernate, Unitsofmeasurement.org, JodaTime, or others;-) > >> > >> If we mixed the two we also ended up with something very close to > Spring;-D > >> > >> Werner > >> > >> > >> > >> On Mon, Jan 26, 2015 at 11:27 AM, Romain Manni-Bucau < > >> [email protected]> > >> wrote: > >> > >>> API only IMO. Duplication is saner than depending on core and finally > >>> showing that your module is not able to work with any implementation > >>> as it should - otherwise just merge core and api. > >>> > >>> > >>> Romain Manni-Bucau > >>> @rmannibucau > >>> http://www.tomitribe.com > >>> http://rmannibucau.wordpress.com > >>> https://github.com/rmannibucau > >>> > >>> > >>> 2015-01-26 11:25 GMT+01:00 Oliver B. Fischer <[email protected] > >: > >>>> Dear all, > >>>> > >>>> one IMHO important question after various changes to the "in-progress" > >>>> builder module is: Should modules be allowed to reuse code from core? > >>>> > >>>> I think definitly yes? Why should we duplicate code and - much worse - > >>>> logic? > >>>> > >>>> Bye, > >>>> > >>>> Oliver > >>>> > >>>> -- > >>>> N Oliver B. Fischer > >>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany > >>>> P +49 30 44793251 > >>>> M +49 178 7903538 > >>>> E [email protected] > >>>> S oliver.b.fischer > >>>> J [email protected] > >>>> X http://xing.to/obf > >>>> > >>> > >> > > > > > > > > -- > > *Anatole Tresch* > > Java Engineer & Architect, JSR Spec Lead > > Glärnischweg 10 > > CH - 8620 Wetzikon > > > > *Switzerland, Europe Zurich, GMT+1* > > *Twitter: @atsticks* > > *Blogs: **http://javaremarkables.blogspot.ch/ > > <http://javaremarkables.blogspot.ch/>* > > > > *Google: atsticksMobile +41-76 344 62 79* > >
