IMO there are numerous alternatives much better than adding an additional dependency. Adding a dependency to the core is somehow similar as you write a CDI module that depends on e.g. Weld. Additionally, if really much duplication is needed, it might be even useful to add some functionality as part of the API. In the builder case, e.g. it is the functionality of creating a Configuration bsed on a ConfigurationContext. Given the fact that we already have a ConfigurationProvider singleton (and a corresponding SPI), we should discuss if we want to add one single factory method, e.g. something like Configuration createFrom(ConfigurationContext); Given that the core can implement it and we can avoid the impl dependency completely ;)
2015-01-26 11:25 GMT+01:00 Oliver B. Fischer <[email protected]>: > Dear all, > > one IMHO important question after various changes to the "in-progress" > builder module is: Should modules be allowed to reuse code from core? > > I think definitly yes? Why should we duplicate code and - much worse - > logic? > > Bye, > > Oliver > > -- > N Oliver B. Fischer > A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany > P +49 30 44793251 > M +49 178 7903538 > E [email protected] > S oliver.b.fischer > J [email protected] > X http://xing.to/obf > > -- *Anatole Tresch* Java Engineer & Architect, JSR Spec Lead Glärnischweg 10 CH - 8620 Wetzikon *Switzerland, Europe Zurich, GMT+1* *Twitter: @atsticks* *Blogs: **http://javaremarkables.blogspot.ch/ <http://javaremarkables.blogspot.ch/>* *Google: atsticksMobile +41-76 344 62 79*
