When I look at this code I see that there's probably a fair bit of work to do to bring this up to a level that would fit for commons. Since this does not really add any value for maven users I'm not immediately willing to do this; I have other higher-value targets in sight. Maybe sometime later. If anyone else wants to tweak it around and submit this I'm fine with that.
Kristian 2015-01-10 16:51 GMT+01:00 Kristian Rosenvold <kristian.rosenv...@gmail.com>: > I'm probably mixing threads here. Better to do so in email than in code :) > > The file we're talking about is > https://github.com/sonatype/plexus-archiver/blob/2.x/src/main/java/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.java > > > Kristian > > > > 2015-01-10 16:46 GMT+01:00 Stefan Bodewig <bode...@apache.org>: >> On 2015-01-10, Kristian Rosenvold wrote: >> >>> 10. jan. 2015 15:19 skrev "Jason van Zyl" <ja...@takari.io>: >> >>>> So I took a look and my feedback: >> >>>> You have a blurb about how to use the parallel code in commons-compress >>>> but there is no test or example that actually shows how to make one. The >>>> actual working example is in plexus-archiver and if you don't mind I'd like >>>> to put a utility in commons-compress so that users can easily utilize the >>>> code. Basically "use this number of threads and you go make it faster". >>>> Something like the ConcurrentJarCreator but general purpose, and that >>>> utility can probably be used, with instruction from the user, to do the >>>> work in parallel. It would be really nice just to weave the code into the >>>> existing code paths so users just get the benefit with an upgrade. >> >> >>> I originally had ConcurrentJarCreator in my c-compress fork. We discussed >>> this (arguably somewhat briefly) on the commons mailing list and to my >>> understanding Stefan wants c-c to be more of a toolkit (at a slightly lower >>> level) and did not want this in c-compress. >> >> Really, I don't remember saying anything to that effect, and of course >> there are more folks than just me. Might be me getting old :-) >> >> Let me have another look at ConcurrentJarCreator (likely not today, >> though). I agree we should be having this discussion on dev@commons. >> >> Stefan >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
