Github user chlowell commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r134355177
--- Diff: tests/src/Context/LogicalThreadContextTest.cs ---
@@ -17,7 +17,7 @@
//
#endregion
-#if NET_4_5 || NETSTANDARD1_3
+#if NET_4_5 || NETCOREAPP1_0 || NETCOREAPP2_0
--- End diff --
I find that less clear because it confuses .NET Standard and .NET Core, and
suggests targeting `netstandard1.3` and `netcoreapp1.0` simultaneously, which
is bizarre. A .NET Standard version is similar to a PCL profile here: an
abstract, runtime-agnostic API contract, not a platform on which code runs.
Test projects build executables because tests must run on some platform, like
.NET Core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
