jeanouii commented on code in PR #134:
URL: https://github.com/apache/johnzon/pull/134#discussion_r2984415424
##########
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/converter/BigDecimalConverter.java:
##########
@@ -25,7 +25,9 @@
public class BigDecimalConverter implements Converter<BigDecimal> {
@Override
public String toString(final BigDecimal instance) {
- return instance.toString();
+ // when using the converter, user expects the decimal notation
+ // otherwise, JsonNumber will give the E (scientific) notation
+ return instance.toPlainString();
Review Comment:
Well, no reason to write a string version of the E notation if this is
already the default for JsonNumber. It's a String here, so I think it makes
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
