jeanouii commented on code in PR #134:
URL: https://github.com/apache/johnzon/pull/134#discussion_r2984405958
##########
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/map/LazyConverterMap.java:
##########
@@ -85,8 +85,8 @@ public Object from(final Object a) {
private boolean useShortISO8601Format = true;
private DateTimeFormatter dateTimeFormatter;
- private boolean useBigIntegerStringAdapter = true;
- private boolean useBigDecimalStringAdapter = true;
+ private boolean useBigIntegerStringAdapter = false; // Jakarta JSON-B 3.0
Section 3.4.1 (BigDecimal MUST be a JSON number)
Review Comment:
In reality, I did not change the default, I made them respect the behavior
we had :-)
Leaving them to true breaks tons of tests, because it was not used before
(swapped properties and Mappings.java skipping the adapter for write)
The "breaking change" is purely theoretical here.
RFC 8259 and Jakarta JSON-B both expect BigDecimal to be a JSON number. So
it is just reflecting the way it was working before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
