rmannibucau commented on code in PR #134:
URL: https://github.com/apache/johnzon/pull/134#discussion_r2984382517
##########
johnzon-mapper/src/main/java/org/apache/johnzon/mapper/map/LazyConverterMap.java:
##########
@@ -85,8 +85,8 @@ public Object from(final Object a) {
private boolean useShortISO8601Format = true;
private DateTimeFormatter dateTimeFormatter;
- private boolean useBigIntegerStringAdapter = true;
- private boolean useBigDecimalStringAdapter = true;
+ private boolean useBigIntegerStringAdapter = false; // Jakarta JSON-B 3.0
Section 3.4.1 (BigDecimal MUST be a JSON number)
Review Comment:
this default is super important, it is the only guarantee you can have round
trips, disabling it make the read/write polymorphic when you overflow supported
number range which is totally broken from a typed pr parser point of view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
