Hi Aaron / Kirk, Thank you for the update. As Owen has mentioned that if there is a change request from someone with write permission to the branch, we should address it, or request a re-review. In the "rogue developer" case which Kirk mentioned, and I hope that this does not happen in the Apache Geode community, -- Halena has mentioned that a review can be dismissed.
Please do let me know if there are any more information requests. Regards Naba On Thu, Oct 24, 2019 at 3:43 PM Aaron Lindsey <alind...@pivotal.io> wrote: > @Naba That's the one. It was approved shortly after I sent that message > though. It should be reproducible by requesting changes on a PR with no > other reviews. > > @Owen It's unclear to me whether "requesting changes" is the same thing as > a -1 vote. I had previously discussed this with some other committers who > were under the impression that they were not the same thing. > > @Helena Thanks! I didn't know that was possible. > > - Aaron > > > On Thu, Oct 24, 2019 at 3:02 PM Nabarun Nag <n...@apache.org> wrote: > > > @Aaron : which PR are you referring to? I can only see "GEODE-7326: Add > > cache gets timers" which can be merged? I can get some more idea when I > can > > see whats going on. > > > > Regards > > Naba > > > > @Kirk : let me run some experiments. > > > > Regards > > Naba > > > > > > On Thu, Oct 24, 2019 at 2:57 PM Helena Bales <hba...@pivotal.io> wrote: > > > > > To Kirk's point, there is actually a way to dismiss requests for > review. > > > Info here: > > > > > > > > > https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/dismissing-a-pull-request-review > > > There's instructions in there for how to dismiss a request for changes. > > Not > > > everyone can do that, so if you aren't a contributor yet you'll > probably > > > have to hit up a current contributor to get any requests for changes > > > dismissed. > > > > > > On Thu, Oct 24, 2019 at 2:52 PM Kirk Lund <kl...@apache.org> wrote: > > > > > > > One side effect is that any single request for changes will now > > > completely > > > > block merging the PR. I'm not certain this was intentional? One rogue > > > > developer could block the merging of any or every PR. I'm not sure > one > > > > person should have that much power... > > > > > > > > On Thu, Oct 24, 2019 at 2:25 PM Nabarun Nag <n...@apache.org> wrote: > > > > > > > > > Hi, Geode dev Community, > > > > > > > > > > This is an announcement that the GitHub branch protection rules are > > > *now > > > > > active* on develop branch for Apache Geode. > > > > > > > > > > The following rules are currently active : > > > > > - Require pull request reviews before merging - at least 1 > > > > > - Require status checks to pass before merging > > > > > [Only for > > > > > - concourse-ci/Build > > > > > - concourse-ci/UnitTestOpenJDK11 > > > > > - concourse-ci/UnitTestOpenJDK8 > > > > > - concourse-ci/StressNewTestOpenJDK11] > > > > > > > > > > After we stabilize the remaining test suites, we can add them to > > these > > > > rule > > > > > sets. > > > > > > > > > > Also reminding the community to use squash merge while closing pull > > > > > requests. > > > > > > > > > > Regards > > > > > Naba > > > > > > > > > > > > > > >
