Thanks, Naba. Are we now blocking merges for PRs that have changes requested?
I have a PR right now where instead of the merge button it has the message, "Merging can be performed automatically once the requested changes are addressed." It also happens to not have any approvals, so it's possible that the merge is actually blocked because there are no approvals. In this case I find the message misleading. - Aaron On Thu, Oct 24, 2019 at 2:25 PM Nabarun Nag <n...@apache.org> wrote: > Hi, Geode dev Community, > > This is an announcement that the GitHub branch protection rules are *now > active* on develop branch for Apache Geode. > > The following rules are currently active : > - Require pull request reviews before merging - at least 1 > - Require status checks to pass before merging > [Only for > - concourse-ci/Build > - concourse-ci/UnitTestOpenJDK11 > - concourse-ci/UnitTestOpenJDK8 > - concourse-ci/StressNewTestOpenJDK11] > > After we stabilize the remaining test suites, we can add them to these rule > sets. > > Also reminding the community to use squash merge while closing pull > requests. > > Regards > Naba >
