From https://www.apache.org/foundation/voting.html

"A code-modification proposal may be stopped dead in its tracks by a -1 vote by 
a qualified voter."

So I think this is consistent with Apache guidelines...

> On Oct 24, 2019, at 2:51 PM, Kirk Lund <kl...@apache.org> wrote:
> 
> One side effect is that any single request for changes will now completely
> block merging the PR. I'm not certain this was intentional? One rogue
> developer could block the merging of any or every PR. I'm not sure one
> person should have that much power...
> 
> On Thu, Oct 24, 2019 at 2:25 PM Nabarun Nag <n...@apache.org> wrote:
> 
>> Hi, Geode dev Community,
>> 
>> This is an announcement that the GitHub branch protection rules are *now
>> active* on develop branch for Apache Geode.
>> 
>> The following rules are currently active :
>> - Require pull request reviews before merging - at least 1
>> - Require status checks to pass before merging
>>     [Only for
>>                - concourse-ci/Build
>>               - concourse-ci/UnitTestOpenJDK11
>>               - concourse-ci/UnitTestOpenJDK8
>>               - concourse-ci/StressNewTestOpenJDK11]
>> 
>> After we stabilize the remaining test suites, we can add them to these rule
>> sets.
>> 
>> Also reminding the community to use squash merge while closing pull
>> requests.
>> 
>> Regards
>> Naba
>> 

Reply via email to