+1 Ran geode-release-check (checks signatures, source build, simple gfsh test)
-Dan On Mon, Sep 23, 2019 at 3:20 PM Jacob Barrett <jbarr...@pivotal.io> wrote: > +1 > > Still think it is ok to ship but found another annoying issue. When > running Geode Native C++ integration tests (new framework) an indented > disabled test will execute and fail. The test was not properly disabled. On > the develop branch this test is fixed and is no longer disabled. If there > is another RC we could easily port the fix or properly disable the test. > > -Jake > > > On Sep 23, 2019, at 2:36 PM, Jacob Barrett <jbarr...@pivotal.io> wrote: > > > > +1 > > > > Only tested geode-native on MacOS. Unit and integration tests based. > > > > One issues worth mentioning, while we don’t explicitly state support for > specific platforms, MacOs with the latest Xcode will have some troubles > getting off the ground. The updated Clang compiler in Xcode is less > forgiving and has some new warnings/errors. This same issue will likely > exist in other platforms where newer versions of Clang are in use. Adding a > few warning exclusions on your CMake configuration command will get you > past the errors. > > > > cmake ... -DCMAKE_CXX_FLAGS="-Wno-defaulted-function-deleted > -Wno-c++2a-compat" > > > > -Jake > > > > > > > >
